Updating the Glean SDK

Project FOG uses the published Glean SDK. It currently depends on glean-core from crates.io.

To update the dependency:

  1. Bump the version of the glean crate in toolkit/components/glean/Cargo.toml and toolkit/components/glean/api/Cargo.toml.

  2. Run mach vendor rust. This fetches all dependencies and adds them to third_pary/rust.

  3. Update the version of gleanVersion in build.gradle to the same version.

  4. Update the version of glean-sdk in build/mach_virtualenv_packages.txt.

Version mismatches of Rust dependencies

Other crates that are already vendored might require a different version of the same dependencies that the Glean SDK requires. The general strategy for Rust dependencies is to keep one single version of the dependency in-tree (see comment #8 in bug 1591555). This might be hard to do in reality since some dependencies might require tweaks in order to work. The following strategy can be followed to decide on version mismatches:

  • If the versions only differ by the patch version, Cargo will keep the vendored version, unless some other dependency pinned specific patch versions; assuming it doesn’t break the Glean SDK; if it does, follow the next steps;

  • If the version of the vendored dependency is newer (greater major or minor version) than the version required by the Glean SDK, file a bug in the Glean SDK component to get Glean to require the same version;

  • If the version of the vendored dependency is older (lower major or minor version), consider updating the vendored version to the newer one; seek review from the person who vendored that dependency in the first place; if that is not possible or breaks mozilla-central build, then consider keeping both versions vendored in-tree; please note that this option will probably only be approved for small crates.

Keeping versions in sync

The Glean SDK and glean_parser are currently released as separate projects. However each Glean SDK release requires a specific glean_parser version. When updating one or the other ensure versions stay compatible. You can find the currently used glean_parser version in the Glean SDK source tree, e.g. in sdk_generator.sh.